Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Cloud Docker 1.2.0 Release #8199

Merged
merged 25 commits into from
Nov 9, 2020
Merged

Conversation

meker12
Copy link
Contributor

@meker12 meker12 commented Nov 6, 2020

Purpose of this pull request

Adds release notes and documentation updates for Magento Cloud Docker 1.2.0 release.

Affected DevDocs pages

whatsnew
Magento Cloud Docker 1.2.0 release notes and updates:

  • Updated the Set up email topic to add instructions for configuring HTTP and SMTP ports and disabling MailHog in a Magento Cloud Docker environment.

  • Added instructions for configuring the Docker host name for the Xdebug container when running Magento Cloud Docker on Linux.

  • Added instructions for updating the Elasticsearch plugin configuration in a Magento Cloud Docker environment.

  • Added instructions for building a custom docker-compose.yaml file.

oshmyheliuk and others added 12 commits September 3, 2020 13:19
* MCLOUD-6430: Xdebug not working on Magento Cloud Docker 1.1

* Update src/cloud/docker/docker-development-debug.md

Co-authored-by: Barny Shergold <[email protected]>

* Update src/cloud/docker/docker-development-debug.md

Co-authored-by: Jeff Matthews <[email protected]>

Co-authored-by: Barny Shergold <[email protected]>
Co-authored-by: Jeff Matthews <[email protected]>
* MCLOUD-6898: Add option to customize port for MailHog
* MCLOUD-6660: Add option to disable MailHog
* Update src/cloud/docker/docker-config.md

Co-authored-by: Margaret Eker <[email protected]>
* MCLOUD-2789: [Cloud Docker] Add support for adding custom ES plugins from services.yaml file to the docker-compose.yml file.

Co-authored-by: Margaret Eker <[email protected]>
* MCLOUD-6394: Help with running MFTF test generation commands
* Added `--with-test` option to `build:compose` option list

* Update src/cloud/docker/docker-containers.md
  - Added test container

* Update src/cloud/docker/docker-containers-service.md
  
   Added `--with-test` option to `build:compose` option list

Co-authored-by: Barny Shergold <[email protected]>
Co-authored-by: Margaret Eker <[email protected]>
* Updated Docker Quick reference

- Addedd new options to the magento-docker CLI
- Added listing that shows all available options for ece-docker
build:compose command
- Added intro to Docker Compose section

* Update src/cloud/docker/docker-quick-reference.md

Co-authored-by: maeker12 <{ID}+{username}@users.noreply.github.com>
* Updated Docker Quick reference

- Addedd new options to the magento-docker CLI
- Added listing that shows all available options for ece-docker
build:compose command
- Added intro to Docker Compose section

* MCLOUD-7809 Added instructions for building custom docker-compose.yaml file

* Improved instructions for using the init-docker.sh installation script

* Updates for Magento Cloud Docker 1.2.0 release notes

Co-authored-by: maeker12 <{ID}+{username}@users.noreply.github.com>
@meker12 meker12 added 2.x Major Update Significant original updates to existing content Internal Dev Differentiates work between community and Magento staff labels Nov 6, 2020
@meker12 meker12 self-assigned this Nov 6, 2020
@meker12 meker12 changed the title Cloud docker 1.2.0 Cloud Docker 1.2.0 Release Nov 6, 2020
@meker12 meker12 requested review from hguthrie and bdenham November 6, 2020 21:45
@andriyShevtsov
Copy link
Contributor

QA approved

Copy link
Contributor

@hguthrie hguthrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few problems I noted. Also not part of your changes, but I noticed Line 180 of containers topic (selenium) looks like it has a broken link. I think it needs a closing paren.

The `analysis-icu` and `analysis-phonetic` plugins are installed by default and can not be skipped.
If you use Elasticsearch 6.5 and later, the default Elasticsearch plugins configured in `.magento/services.yaml` are installed automatically along with any custom plugins added to the `services.yaml`. When you generate the `docker-compose.yaml` file, custom plugins are added to the `ES_PLUGINS` environment configuration option.

You can change the list of plugins to install by updating the configuration for the `ES_PLUGINS` variable:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a little more description about the example. Something like "The following example adds the..."
You said you can "change" the list. Does it add analysis-stempel and analysis-nori to an existing list? Or is that the full list?

## Test container

**Container name**: test<br/>
**Docker base image**: [magento/magento-cloud-docker-php][php-cloud], which is based on the [php](https://hub.docker.com/_/php) Docker image<br/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why say based-on here when it is in the following paragraph?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handled inconsistently. Moved "based on ... Docker image" to the header info for all containers.


- **Run commands inside Docker PHP containers**–Now you can use the Magento Cloud Docker CLI to run commands inside PHP containers in your Docker environment without having to install PHP on the host. For example, the following command builds the configuration: `./bin/magento-docker php 7.3 vendor/bin/ece-docker build:compose`. See [Magento Cloud Docker CLI]({{ site.baseurl }}/cloud/docker/docker-quick-reference.html#magento-cloud-docker-cli). *[Fix submitted by G Arvind from Zilker Technology](https://github.com/magento/magento-cloud-docker/pull/209).*<!--MCLOUD-5982-->

- Added the OpenSSH-client to PHP CLI containers so you can use ssh-agent forwarding for Composer if the `composer.json` file contains private git repositories that require an ssh client for various Composer commands.<!--MCLOUD-6008-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is a mouth-full. I'm sure there is a use for a comma here.

@meker12 meker12 requested a review from hguthrie November 9, 2020 16:27
Copy link
Contributor

@hguthrie hguthrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

maeker12 and others added 2 commits November 9, 2020 10:54
to apply patches before deploying to a Magento Cloud
Docker environment
@meker12 meker12 changed the base branch from master to cloud-packages-november-release November 9, 2020 16:56
@meker12 meker12 merged commit 6bcb986 into cloud-packages-november-release Nov 9, 2020
@ghost
Copy link

ghost commented Nov 9, 2020

Hi @meker12, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

meker12 added a commit that referenced this pull request Nov 9, 2020
* ECE-Tools 2002.1.3 docs and release notes (#8161)

* MCLOUD-6939: Errors occur running magento commands in composer cloud docker installation (#8007)

* Added variable to skip composer dump-autoload command processing when deploying a Magento Cloud project to a Cloud Docker environment.

* MCLOUD-7072: Add CLI command for generating .magento.env.yaml (#8040)

* MCLOUD-7072: Add CLI commands for creating and updating .magento.env.yaml
* Apply suggestions from code review
Co-authored-by: Barny Shergold <[email protected]>
Co-authored-by: Margaret Eker <[email protected]>

* MCLOUD-6805: ECE-Tools release notes

WIP: updating variables

* MCLOUD-6805: ECE-Tools release notes

First draft

* MCLOUD-6805: ECE-Tools release notes

Fixed double slash on link

* added links to two  hot fixes

* Update services-mysql.md (#8051 
* Update Magento Cloud Docker instructions for adding custom PHP extensions (#8145)

* [Doc] Adding new PHP extensions #155 (#7929)

* Clean up instructions for adding PHP extensions
- Move extension configuration attribute descriptions and examples
to a separate section
* Fixed markdown syntax
* Fix link definitions
* Fix link syntax

* Apply suggestions from code review

Co-authored-by: Yevhen Miroshnychenko <[email protected]>
Co-authored-by: Barny Shergold <[email protected]>
Co-authored-by: hguthrie <[email protected]>

* MCLOUD-6805: ECE-Tools release notes

Updated entry for MCLOUD-7098

* MCLOUD-6805: ECE-Tools release notes

Fixed merge conflicts

* Added docs for SKIP_COMPOSER_DUMP_AUTOLOAD

* Apply suggestions from code review

Co-authored-by: Margaret Eker <[email protected]>

* MCLOUD-6805: ECE-Tools release notes

Added release notes entry for #7191

* Update error-codes information with current info (#8152)

* Update error-codes information with current info

- Replaced file with error-code.md file generated from the ece-tools package

* Fixed error messages

* Add source file for generating the error code ref

Co-authored-by: Barny Shergold <[email protected]>

* Fixed comment syntax on internal note

* MCLOUD-6805: ECE-Tools release notes

Added release not for MCLOUD-7193

* MCLOUD-6805: ECE-Tools release notes

Fixed silly empty bullet

* MCLOUD-6805: ECE-Tools release notes

Per review, updated additional ece-tools docs changes that are unassociated with the release notes.

* MCLOUD-6805: ECE-Tools release notes

Per review, removed extra space from yaml code block.

* MCLOUD-6805: ECE-Tools release notes

Per review, tweaking the wording for writeable Cloud Docker environments.

* MCLOUD-6805: ECE-Tools release notes

Per review, forgot to clarify the pronoun that.

* MCLOUD-6805: ECE-Tools release notes

Per review, removed extra space, missed it first time around.

* MCLOUD-6805: ECE-Tools release notes

Ordered 'new' release note before fixed

* MCLOUD-6805: ECE-Tools release notes

Added links to documentation.

* MCLOUD-6805: ECE-Tools release notes

Added links to documentation.
* Apply suggestions from code review

* Cloud Docker 1.2.0 Release (#8199)

* MCLOUD-6430: Xdebug not working on Magento Cloud Docker 1.1 (#7810)
* Update src/cloud/docker/docker-development-debug.md
* MCLOUD-6898: Add option to customize port for MailHog (#7860)
* MCLOUD-6898: Add option to customize port for MailHog
* MCLOUD-6660: Add option to disable MailHog
* Update src/cloud/docker/docker-config.md
* MCLOUD-2789: [Cloud Docker] Add custom ES plugins (#7898)
* MCLOUD-2789: [Cloud Docker] Add support for adding custom ES plugins from services.yaml file to the docker-compose.yml file.
* MCLOUD-6394: Help with running MFTF test generation commands (#7995)
* MCLOUD-6394: Help with running MFTF test generation commands
* Added `--with-test` option to `build:compose` option list
* Update src/cloud/docker/docker-containers.md
  - Added test container
* Update src/cloud/docker/docker-containers-service.md
   Added `--with-test` option to `build:compose` option list
* Update Docker command help (#8197)
* Updated Docker Quick reference
- Addedd new options to the magento-docker CLI
- Added listing that shows all available options for ece-docker
build:compose command
- Added intro to Docker Compose section
* Updates for Cloud Docker 1.2.0 release (#8198)
* MCLOUD-7809 Added instructions for building custom docker-compose.yaml file
* Improved instructions for using the init-docker.sh installation script
* Updates based on review feedback
* Updated Launch developer mode instructions to add step
to apply patches before deploying to a Magento Cloud
Docker environment

Co-authored-by: Oleksandr Shmyheliuk <[email protected]>
Co-authored-by: Andrii Shevtsov <[email protected]>
Co-authored-by: Margaret Eker <[email protected]>
Co-authored-by: Yevhen Miroshnychenko <[email protected]>
Co-authored-by: Barny Shergold <[email protected]>
Co-authored-by: hguthrie <[email protected]>
Co-authored-by: Jeff Matthews <[email protected]>
Co-authored-by: Bohdan Korablov <[email protected]>
@meker12 meker12 deleted the Cloud-Docker-1.2.0 branch November 9, 2020 20:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.x Internal Dev Differentiates work between community and Magento staff Major Update Significant original updates to existing content Progress: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants